bpo-40600: atexit only loads single time per interpreter#23699
Closed
corona10 wants to merge 5 commits into
Closed
bpo-40600: atexit only loads single time per interpreter#23699corona10 wants to merge 5 commits into
corona10 wants to merge 5 commits into
Conversation
vstinner
requested changes
Dec 8, 2020
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
I would prefer to move the atexit list of callbacks into PyInterpreterState, and the atexit module would get the list from the current interpreter.
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be put in the comfy chair! |
Member
Author
|
@vstinner Ah okay, I will update the PR by tomorrow ;) |
corona10
force-pushed
the
bpo-40600-iss
branch
2 times, most recently
from
d9bee4e to
9c4d2b0
Compare
corona10
force-pushed
the
bpo-40600-iss
branch
from
68d795c to
eef1ce0
Compare
Member
Author
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
corona10
changed the title
Member
|
This is solved in a different way in bpo-42639. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40600